-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move detailed per CPU kernel stats under a new flag METRICS_V2_KERNEL_COUNTERS_PER_CPU
#2028
Comments
/milestone 0.18.0 |
Yes, it makes sense, I will take care of it! Thank you for the suggestion |
Thank you Andrea! Few more thoughts:
|
Yep I agree
Yeah, it seems a great idea but I'm not sure what is the right place to obtain them. Definitely not an expert in metrics representation but is not possible to obtain these kinds of data directly in Prometheus or something similar starting from the metrics we expose today? |
On top of my head one pro could be to save the space of sending many raw metric fields for machines with many CPUs. |
that's a good point. Let's say that I see these per-CPU metrics more as a debug option than something to run in production by default, if we end up using them we are probably in a critical situation with performance issues, so the overhead introduced by them could be acceptable since we are trying to debug...so yes statistical metrics are for sure useful but I'm not 100% sure this is the right case to apply them, WDYT? |
The new detailed kernel counters per CPU are great. At the same time it can add a lot of metrics, especially for beefy server with 128+ CPUs. Therefore proposing to move them under a new flag, e.g.
METRICS_V2_KERNEL_COUNTERS_PER_CPU
and expose a sub-config key in Falco to allow users to opt in or opt out of these new counters.CC @Andreagit97 WDYT?
If we all agree we should prioritize this for 0.18.0 so that we have a coherent UX.
The text was updated successfully, but these errors were encountered: