new(ci,benchmarks): added more benchmarks and make use of them in perf CI

.github/actions/composite-perf/action.yml

@@ -14,6 +14,9 @@ outputs:
  heaptrack_scap:
  description: "Scap file heaptrack data"
  value: ${{ steps.store-outputs.outputs.heaptrack_scap }}
+ gbench_json:
+ description: "Google benchmarks json data"
+ value: ${{ steps.store-outputs.outputs.gbench_json }}
 
 runs:
  using: "composite"
@@ -28,8 +31,9 @@ runs:
  shell: bash
  run: |
  mkdir -p build
- cd build && cmake -DUSE_BUNDLED_DEPS=False -DCMAKE_BUILD_TYPE=Debug ../
+ cd build && cmake -DUSE_BUNDLED_DEPS=False -DCMAKE_BUILD_TYPE=Debug -DENABLE_BENCHMARKS=True ../
  make unit-test-libsinsp -j4
+ make bench -j4
  make sinsp-example -j4
 
  - name: Download scap file
@@ -70,6 +74,12 @@ runs:
  cd build
  sudo heaptrack -o heaptrack_scap.data ./libsinsp/examples/sinsp-example -s traces-positive/falco-event-generator.scap
 
+ - name: Run - gbench
+ shell: bash
+ run: |
+ cd build
+ ./benchmark/bench --benchmark_repetitions=20 --benchmark_report_aggregates_only --benchmark_out=gbench_data.json --benchmark_out_format=json
+
  - name: Set Outputs
  id: store-outputs
  shell: bash
@@ -79,3 +89,4 @@ runs:
  echo "perf_scap=$(realpath perf_scap.data)" >> $GITHUB_OUTPUT
  echo "heaptrack_tests=$(realpath heaptrack_tests.data.zst)" >> $GITHUB_OUTPUT
  echo "heaptrack_scap=$(realpath heaptrack_scap.data.zst)" >> $GITHUB_OUTPUT
+ echo "gbench_json=$(realpath gbench_data.json)" >> $GITHUB_OUTPUT

.github/workflows/pages.yml

@@ -37,6 +37,7 @@ jobs:
  ${{ steps.perf.outputs.perf_scap }}
  ${{ steps.perf.outputs.heaptrack_tests }}
  ${{ steps.perf.outputs.heaptrack_scap }}
+ ${{ steps.perf.outputs.gbench_json }}
  if-no-files-found: error
 
  - name: Checkout Flamegraph ⤵️

.github/workflows/perf.yml

@@ -15,6 +15,13 @@ jobs:
  - name: Checkout Libs ⤵️
  uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
+ - name: Checkout Google benchmark ⤵️
+ uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+ with:
+ repository: 'google/benchmark'
+ ref: 'v1.9.0'
+ path: google-benchmark/
+
  - name: Run perf
  id: perf
  uses: ./.github/actions/composite-perf
@@ -43,6 +50,11 @@ jobs:
  run: |
  sudo heaptrack_print heaptrack_scap.data.zst -d ${{ steps.perf.outputs.heaptrack_scap }} &> heaptrack_scap_diff.txt
 
+ - name: Diff from master - gbench
+ run: |
+ pip3 install -r google-benchmark/tools/requirements.txt
+ python3 google-benchmark/tools/compare.py --no-color benchmarks gbench_data.json ${{ steps.perf.outputs.gbench_json }} &> gbench_diff.txt
+
  - name: Archive perf diff
  uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
  with:
@@ -75,6 +87,10 @@ jobs:
  echo "\`\`\`" >> ./pr/COMMENT
  tail -n3 "heaptrack_scap_diff.txt" >> ./pr/COMMENT
  echo "\`\`\`" >> ./pr/COMMENT
+ echo "# Benchmarks diff from master" >> ./pr/COMMENT
+ echo "\`\`\`" >> ./pr/COMMENT
+ cat "gbench_diff.txt" >> ./pr/COMMENT
+ echo "\`\`\`" >> ./pr/COMMENT
  echo Uploading PR info...
  cat ./pr/COMMENT
  echo ""
@@ -135,3 +151,15 @@ jobs:
  if [ -s heaptrack_scap_diff_above_thresh.txt ]; then
  exit 2
  fi
+
+ # Check will fail if there any google benchmark is slowed more than 5%
+ - name: Check >= 5% slowdown on google benchmarks
+ if: always() # Even if other threshold checks failed
+ run: |
+ # Remove first 3 lines and last line that are no tests results
+ tail -n+4 gbench_diff.txt | head -n -1 | while read p; do
+ diff_pct=$(echo "$p" | awk '{print $3}' | tr -d '+')
+ if (( $(echo "$diff_pct >= 5.0" | bc -l) )); then
+ exit 1
+ fi
+ done

benchmark/libsinsp/utils.cpp

@@ -27,4 +27,48 @@ static void BM_sinsp_split(benchmark::State& state)
  sinsp_split(str, ',');
  }
 }
-BENCHMARK(BM_sinsp_split)->Repetitions(2);
+BENCHMARK(BM_sinsp_split);
+
+static void BM_sinsp_concatenate_paths_relative_path(benchmark::State& state)
+{
+ std::string path1 = "/tmp/";
+ std::string path2 = "foo/bar";
+ for(auto _ : state)
+ {
+ sinsp_utils::concatenate_paths(path1, path2);
+ }
+}
+BENCHMARK(BM_sinsp_concatenate_paths_relative_path);
+
+static void BM_sinsp_concatenate_paths_empty_path(benchmark::State& state)
+{
+ std::string path1 = "/tmp/";
+ std::string path2 = "";
+ for(auto _ : state)
+ {
+ sinsp_utils::concatenate_paths(path1, path2);
+ }
+}
+BENCHMARK(BM_sinsp_concatenate_paths_empty_path);
+
+static void BM_sinsp_concatenate_paths_absolute_path(benchmark::State& state)
+{
+ std::string path1 = "/tmp/";
+ std::string path2 = "/foo/bar";
+ for(auto _ : state)
+ {
+ sinsp_utils::concatenate_paths(path1, path2);
+ }
+}
+BENCHMARK(BM_sinsp_concatenate_paths_absolute_path);
+
+static void BM_sinsp_split_container_image(benchmark::State& state)
+{
+ std::string container_image = "localhost:12345/library/busybox:1.27.2@sha256:da39a3ee5e6b4b0d3255bfef95601890afd80709";
+ std::string hostname, port, name, tag, digest;
+ for(auto _ : state)
+ {
+ sinsp_utils::split_container_image(container_image, hostname, port, name, tag, digest);
+ }
+}
+BENCHMARK(BM_sinsp_split_container_image);

userspace/libsinsp/utils.cpp

@@ -1363,7 +1363,7 @@ std::vector<std::string> sinsp_split(std::string_view sv, char delim)
  }
 
  std::string_view::size_type start = 0;
- for (std::string_view::size_type i = 0; i < sv.size(); i++)
+  for (std::string_view::size_type i = 0; i < sv.size(); i++)
  {
  if (sv[i] == delim)
  {