Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: sync release 0.18.x #2069

Merged
merged 9 commits into from
Sep 16, 2024
Merged

update: sync release 0.18.x #2069

merged 9 commits into from
Sep 16, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 16, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP and others added 9 commits September 16, 2024 08:58
otherwise test will give wrong result if compiler has -Werror flags,
complained with:

  error: unused variable 'g_ppm_class' [-Werror=unused-variable]

Signed-off-by: Z. Liu <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 16, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Sep 16, 2024
@poiana poiana added the size/XL label Sep 16, 2024
@poiana
Copy link
Contributor

poiana commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 16, 2024

/unhold

Copy link

Perf diff from master - unit tests

     0.66%     +0.93%  [.] sinsp_filter_check::parse_field_name
     4.52%     -0.86%  [.] gzfile_read
     2.72%     +0.84%  [.] sinsp_thread_manager::find_thread
     5.32%     -0.75%  [.] next
     1.30%     -0.75%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     8.00%     -0.72%  [.] sinsp::next
     4.57%     -0.62%  [.] sinsp_evt::load_params
     0.16%     +0.58%  [.] sinsp_fdtable::sinsp_fdtable
     1.47%     +0.52%  [.] sinsp::fetch_next_event
    10.06%     +0.51%  [.] sinsp_parser::reset

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0261         +0.0261           147           151           147           151
BM_sinsp_split_median                                          +0.0308         +0.0307           146           151           146           151
BM_sinsp_split_stddev                                          -0.5181         -0.5177             2             1             2             1
BM_sinsp_split_cv                                              -0.5304         -0.5300             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1372         +0.1372            42            48            42            48
BM_sinsp_concatenate_paths_relative_path_median                +0.1391         +0.1390            42            48            42            48
BM_sinsp_concatenate_paths_relative_path_stddev                +1.3813         +1.3813             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +1.0939         +1.0940             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0024         -0.0024            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0011         -0.0012            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4605         -0.4602             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4592         -0.4589             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0773         +0.0773            46            50            46            50
BM_sinsp_concatenate_paths_absolute_path_median                +0.0758         +0.0757            46            49            46            49
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2682         -0.2690             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3207         -0.3214             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0584         -0.0584           366           345           366           345
BM_sinsp_split_container_image_median                          -0.0576         -0.0576           366           345           366           345
BM_sinsp_split_container_image_stddev                          -0.1768         -0.1767             2             2             2             2
BM_sinsp_split_container_image_cv                              -0.1258         -0.1256             0             0             0             0

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.58%. Comparing base (5b9db23) to head (92aebc8).
Report is 9 commits behind head on release/0.18.x.

Files with missing lines Patch % Lines
userspace/libsinsp/plugin.cpp 25.00% 3 Missing ⚠️
userspace/libsinsp/sinsp.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/0.18.x    #2069      +/-   ##
==================================================
+ Coverage           73.55%   73.58%   +0.02%     
==================================================
  Files                 253      253              
  Lines               31863    31867       +4     
  Branches             5651     5643       -8     
==================================================
+ Hits                23438    23449      +11     
+ Misses               8420     8417       -3     
+ Partials                5        1       -4     
Flag Coverage Δ
libsinsp 73.58% <79.16%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana added the lgtm label Sep 16, 2024
@poiana poiana merged commit d4efc80 into release/0.18.x Sep 16, 2024
56 of 58 checks passed
@poiana poiana deleted the sync/release_0.18.x branch September 16, 2024 07:44
Copy link

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants