class method doclinks target `mod.html#method` instead of `mod.html#class.method` #1046

seeM · 2022-09-13T03:07:30Z

No description provided.

…#class.method`

review-notebook-app · 2022-09-13T03:07:35Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

seeM · 2022-09-13T03:09:22Z

Thanks to @rxavier for the very helpful minimal repro!

Okay! Minimal example

https:/rxavier/test-doclink-method

https://rxavier.github.io/test-doclink-method/

You'll see that the hyperlinked MyClass.method points to a section named method, and not the method show_doc.

class methods doclinks link to mod.html#method instead of `mod.html…

32734e4

…#class.method`

seeM added the bug Something isn't working label Sep 13, 2022

seeM requested review from jph00 and hamelsmu September 13, 2022 03:07

seeM changed the title ~~class methods doclinks link to mod.html#method instead of mod.html#class.method~~ class method doclinks target mod.html#method instead of mod.html#class.method Sep 13, 2022

jph00 merged commit 807aee3 into fastai:master Sep 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

class method doclinks target `mod.html#method` instead of `mod.html#class.method` #1046

class method doclinks target `mod.html#method` instead of `mod.html#class.method` #1046

seeM commented Sep 13, 2022

review-notebook-app bot commented Sep 13, 2022

seeM commented Sep 13, 2022

class method doclinks target mod.html#method instead of mod.html#class.method #1046

class method doclinks target mod.html#method instead of mod.html#class.method #1046

Conversation

seeM commented Sep 13, 2022

review-notebook-app bot commented Sep 13, 2022

seeM commented Sep 13, 2022

class method doclinks target `mod.html#method` instead of `mod.html#class.method` #1046

class method doclinks target `mod.html#method` instead of `mod.html#class.method` #1046