Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1063: ignore _quarto.yml from nbdev-template #1065

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

seeM
Copy link
Member

@seeM seeM commented Sep 15, 2022

No description provided.

@seeM seeM requested review from jph00 and hamelsmu September 15, 2022 02:57
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seeM
Copy link
Member Author

seeM commented Sep 15, 2022

I don't think we can remove _quarto.yml from nbdev-template since we're currently using the same nbdev-template in all nbdev versions, and <2.3.0 still requires _quarto.yml.

@jph00 jph00 merged commit e26cbe5 into fastai:master Sep 15, 2022
@seeM seeM deleted the fix-nbdev-new-quarto-yml branch September 15, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants