Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utility that creates a requirements.txt file from settings.ini #1202

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Nov 6, 2022

This is useful for things like creating HF spaces

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu added the enhancement New feature or request label Nov 6, 2022
@hamelsmu hamelsmu requested a review from jph00 November 6, 2022 05:15
@hamelsmu hamelsmu changed the title utility that creates requirements.txt file utility that creates a requirements.txt file Nov 6, 2022
@hamelsmu hamelsmu changed the title utility that creates a requirements.txt file utility that creates a requirements.txt file from settings.ini Nov 6, 2022
nbdev/release.py Outdated Show resolved Hide resolved
nbdev/release.py Outdated Show resolved Hide resolved
@jph00
Copy link
Member

jph00 commented Nov 6, 2022

Yay so happy to see this code @hamelsmu ! :D

@hamelsmu
Copy link
Member Author

hamelsmu commented Nov 6, 2022

@jph00 Thanks for the careful code review, appreciate it

@hamelsmu hamelsmu merged commit f7dd526 into master Nov 6, 2022
@hamelsmu hamelsmu deleted the hf-space branch November 6, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants