update install_quarto to distinguish arm64 and amd64 #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_install_linux now infers the machine and installs the appropriate quarto version accordingly. Addresses issue for example when running a devcontainer for development with VSCode. Concrete case using the image `mcr.microsoft.com/devcontainers/python:1-3.11-bullseye` on an Apple M2 machine. This caused the quarto installation to fail since `sys.platform` in the devcontainer is linux but the arm64, not amd64, distribution of Quarto is needed.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_install_linux now infers the machine and installs the appropriate quarto version accordingly.
Addresses issue for example when running a devcontainer for development with VSCode.
Concrete case using the image
mcr.microsoft.com/devcontainers/python:1-3.11-bullseyeon an Apple M2 machine. This caused the quarto installation to fail sincesys.platformin the devcontainer is linux but the arm64, not amd64, distribution of Quarto is needed.