Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive flag #433

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Fix recursive flag #433

merged 2 commits into from
Feb 20, 2021

Conversation

hamelsmu
Copy link
Member

@hamelsmu hamelsmu commented Feb 20, 2021

It turns out that uncommenting and putting recursive=False explicitly was not handled correctly.

This fixes #423

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hamelsmu hamelsmu merged commit 242bd33 into master Feb 20, 2021
@hamelsmu hamelsmu deleted the fix-recursive branch February 20, 2021 23:24
@hamelsmu hamelsmu added the bug Something isn't working label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbdev_build_lib seems to convert more notebooks than expected
1 participant