Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate config_key in favor of get_config #856

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

seeM
Copy link
Member

@seeM seeM commented Aug 14, 2022

@seeM seeM added the enhancement New feature or request label Aug 14, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seeM
Copy link
Member Author

seeM commented Aug 14, 2022

Will fix later today

@jph00
Copy link
Member

jph00 commented Aug 14, 2022

Great idea to add the deprecation warning - thanks!

@jph00 jph00 merged commit c33306c into fastai:master Aug 14, 2022
@jph00 jph00 added breaking and removed enhancement New feature or request labels Aug 14, 2022
@seeM seeM deleted the depr-config-key branch September 9, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants