Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show_doc treats functions decorated with lru_cache as classes #862

Closed
wants to merge 1 commit into from
Closed

show_doc treats functions decorated with lru_cache as classes #862

wants to merge 1 commit into from

Conversation

seeM
Copy link
Member

@seeM seeM commented Aug 15, 2022

@hamelsmu @jph00, not sure if this is a good solution?

@seeM seeM added the bug Something isn't working label Aug 15, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@seeM
Copy link
Member Author

seeM commented Aug 15, 2022

Maybe a better solution is to use sym.__wrapped__ if it exists

@seeM
Copy link
Member Author

seeM commented Aug 15, 2022

Just realised show_doc also isn't showing a param table for these functions

@jph00
Copy link
Member

jph00 commented Aug 15, 2022

In general I suspect we should be using __wrapped__ when it's available.

@jph00
Copy link
Member

jph00 commented Aug 15, 2022

I've just changed it to use __wrapped__ instead - seems to work OK.

@jph00 jph00 closed this Aug 15, 2022
@seeM seeM deleted the fix-showdoc-lru-cache branch August 15, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seeM @jph00