Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run nbdev_readme in nbdev_new #919

Merged
merged 3 commits into from
Aug 23, 2022
Merged

run nbdev_readme in nbdev_new #919

merged 3 commits into from
Aug 23, 2022

Conversation

seeM
Copy link
Member

@seeM seeM commented Aug 23, 2022

I also removed the end-to-end tests. I don't think they were adding much in the way of tests or docs. We can re-add something like them if these commands turn out to be problematic, which I think is unlikely. cc @hamelsmu @jph00

@seeM seeM added the enhancement New feature or request label Aug 23, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00 jph00 merged commit f72b7f6 into fastai:master Aug 23, 2022
@seeM seeM deleted the e2e branch September 9, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants