Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard and prepare for standard lint #44

Merged
merged 4 commits into from
Nov 30, 2021
Merged

add standard and prepare for standard lint #44

merged 4 commits into from
Nov 30, 2021

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Nov 30, 2021

This PR is also for discussing if we should switch to standardjs, like fastify core.

This PR adds all the changes, which need to be done manually to be conform with standardjs. It is easier to review the changes, which have to be done manually before doing a lint:fix, than doing a lint:fix and then fixing manually the stuff, which standardjs could not handle.

I excluded deps/encoding as it is kind of a standalone part and messing with it is potentially critical. Also encoding-indexes.js is a huge file, so having it in a "compressed" format makes sense.

So if we agree on using standardjs like fastify core does, we should merge this, and in a second PR we would just run npm run lint:fix and changing to standard for npm run lint in package.json.Also dont forget to add standard to extends attribute of eslint-configuration.

Checklist

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2021

Maybe we have to downgrade to eslint 7, till standard/eslint-config-standard#193 lands

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2021

But we could also independently integrate the code changes to be prepared anyway.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2021

@kibertoad I downgraded eslint for now. Just want to make sure: Still holding on to your approval?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Nov 30, 2021

Preparing now the follow up, to enforce standard js

@Uzlopak Uzlopak merged commit 1482b86 into fastify:master Nov 30, 2021
@kibertoad
Copy link
Member

sure, I'm ok with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants