Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume property to Sphere #75

Closed
dabiged opened this issue Nov 12, 2020 · 2 comments · Fixed by #152
Closed

Add volume property to Sphere #75

dabiged opened this issue Nov 12, 2020 · 2 comments · Fixed by #152
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)

Comments

@dabiged
Copy link
Contributor

dabiged commented Nov 12, 2020

The proposed Triaxial Ellipsoid class has a volume method.
For consistency a similar method should be created for the Sphere and (biaxial) ellipsoid classes too.

Mentioned by @santisoler in #72 .

Are you willing to help implement and maintain this feature? Yes/No
@welcome
Copy link

welcome bot commented Nov 12, 2020

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible.

You might also want to take a look at our Contributing Guide and Code of Conduct.

@dabiged dabiged mentioned this issue Nov 12, 2020
Merged
11 tasks
@leouieda leouieda added enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project) labels Nov 12, 2020
@leouieda leouieda changed the title Add volume method to Sphere and Ellipsoid Classes Add volume method to Sphere and Ellipsoid Nov 12, 2020
@leouieda leouieda changed the title Add volume method to Sphere and Ellipsoid Add volume property to Sphere and Ellipsoid Nov 12, 2020
@leouieda leouieda mentioned this issue Jun 24, 2022
Merged
@leouieda leouieda changed the title Add volume property to Sphere and Ellipsoid Add volume property to Sphere Jun 27, 2022
@leouieda
Copy link
Member

Done for the ellipsoid in #132

@leouieda leouieda mentioned this issue Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Idea or request for a new feature good first issue Good for newcomers (doesn’t require deep knowledge of the project)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a volume property for the Sphere fatiando/boule
2 participants
@leouieda @dabiged