Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to calculate the global gravity disturbance #102

Merged
merged 19 commits into from
Jun 1, 2022

Conversation

aguspesce
Copy link
Member

@aguspesce aguspesce commented May 10, 2022

Create an example to calculate the global gravity disturbance using Boule, Esaio and pyGMT to plot.

This idea start in fatiando/ensaio#35

Fix #101

@welcome
Copy link

welcome bot commented May 10, 2022

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@aguspesce aguspesce changed the title Add example to calculate the global gravity disturbance WIP Add example to calculate the global gravity disturbance May 10, 2022
@aguspesce
Copy link
Member Author

@leouieda and @santisoler, Let me know that do you think about this example.

In addition, I have a problem when I try to complete the documentation. It also happens with the CI.
I think that the problem is pygmt... So @leouieda can you help me with this?

env/requirements-docs.txt Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
@leouieda
Copy link
Member

@aguspesce I'll have a look at the text later but for now upgrading PyGMT and making sure it has the right GMT version will help. These two need to be pinned together.

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @aguspesce! Just a small suggestion on the colormap and a fix on the data height.

A final step would be to add this to the toctree in the index file so it shows up in the menu.

Let me know when you're satisfied so I can merge 🙂

tutorials/gravity_disturbance.py Outdated Show resolved Hide resolved
tutorials/gravity_disturbance.py Outdated Show resolved Hide resolved
aguspesce and others added 4 commits May 17, 2022 11:10
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
@aguspesce
Copy link
Member Author

@leouieda, the problem to build the documentation persists. This happens to me on my pc and on the CI.

@leouieda
Copy link
Member

Ah that's entirely my fault. This would never work because the Boule docs were being built with pip instead of conda... I'll try to get a fix for that in soon (or if you're up for it, be my guest 🙂).

@leouieda
Copy link
Member

@aguspesce alright, I pushed some commits that enable the conda-based build of the docs. Everything passes and looks good to me. If you're happy with this, then please let me know and remove the "WIP" from the title and I'll merge this in.

Thanks for doing this!

@aguspesce aguspesce changed the title WIP Add example to calculate the global gravity disturbance Add example to calculate the global gravity disturbance Jun 1, 2022
@aguspesce
Copy link
Member Author

@leouieda thank you for your help, I didn't have time to see how to fix the documentation.
If you like it, merge it!

@leouieda
Copy link
Member

leouieda commented Jun 1, 2022

I like it 🙂

@leouieda leouieda merged commit e860f08 into fatiando:master Jun 1, 2022
@santisoler
Copy link
Member

Thanks @aguspesce for this PR! Feel free to add youself to the AUTHORS.md file. You can open a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an example to calculate the gravity disturbance
3 participants