Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis and Azure for GitHub Actions #57

Merged
merged 14 commits into from
Oct 13, 2020
Merged

Replace Travis and Azure for GitHub Actions #57

merged 14 commits into from
Oct 13, 2020

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Oct 9, 2020

Add GitHub Actions workflows for checking style, testing and deploying
Boule, based on the workflows of Harmonica. Remove TravisCI and Azure
configuration files. Split make check target in two: make black-check and
make flake8. Ditch Travis and Azure badges on README.rst. Add new GitHub
Actions badge. Tests are run on every matrix configuration: all OSs and all
Python versions. Use pip to install dependencies instead of setting up miniconda.

Related to fatiando/maintenance#1

@santisoler santisoler changed the title WIP Replace Travis and Azure for GitHub Actions Replace Travis and Azure for GitHub Actions Oct 9, 2020
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @santisoler thanks for doing this 🙂 I left a few comments. Feel free to merge once those are dealt with.

Before merging, we need to have the PyPI and Test PyPI tokens in the repository secrets.

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@leouieda
Copy link
Member

Before merging, we need to have the PyPI and Test PyPI tokens in the repository secrets.

I just added those. I also sent you an invitation for the Test PyPI accounts of all our packages.

@leouieda
Copy link
Member

@santisoler I tried using the Actions python with pip instead of conda and this cut down the test times from 3-4 minutes to ~1 min. It's really not necessary to use conda for Boule and many of our other packages that don't need complex dependencies. Rockhound might be the exception since now even numba can be pip installed.

This might be a more significant speed up for CI than almost anything else we do.

@santisoler
Copy link
Member Author

Thanks @leouieda for the review and all the changes. I agree with the decision of install everything with pip instead of conda, specially for packages like Boule.

Rockhound might be the exception since now even numba can be pip installed.

I don't know what you meant on this sentence. Did you mean Harmonica?

@leouieda
Copy link
Member

I don't know what you meant on this sentence. Did you mean Harmonica?

I mean that RockHound might require netCDF if we want to run any tests. But if not, then it should be fine. I think harmonica would be fine as well.

@santisoler
Copy link
Member Author

I mean that RockHound might require netCDF if we want to run any tests. But if not, then it should be fine. I think harmonica would be fine as well.

Oh, now I get it! Sure, we can try it out on Harmonica and see if it works.

I think this is looking great. Please merge if no more changes should be made.

@leouieda leouieda merged commit 059433d into master Oct 13, 2020
@leouieda leouieda deleted the gh-actions branch October 13, 2020 19:29
@leouieda
Copy link
Member

Fingers crossed that the deploy works 🤞🏽

@santisoler
Copy link
Member Author

Thanks for merging! Seems that deploys worked as charmed. Though one of the Mac OS tests was cancelled for no reason. Just rerun all jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants