Refactor parsers and support pyproject-only projects #8
Conversation
Refactor the parsers functions into classes, simplify the logic of parsers and add support for projects that only have a `pyproject.toml` file.
|
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
Raise error if pyproject.toml is missing **and** "build" is a requested source. Otherwise just parse setup.cfg for the other required sources. Rename function.
Test if the function that finds configuration files in disk and decide which sources must be parsed from which file works as expected.
|
@leouieda would you mind taking a look at this? I want to have this released so I can continue moving Harmonica to There are some coverage lacking in the classes, mostly on errors raised when some sections aren't found in the configuration files. Let me know what do you think about them and if we should write tests for them as well. |
|
🎉 Congrats on merging your first pull request and welcome to the team! 🎉 If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
Refactor the parsers functions into classes, simplify the logic of parsers and add support for projects that only have a
pyproject.tomlfile.Relevant issues/PRs:
Dependente was failing when moving Harmonica to
pyproject.tomlonly infatiando/harmonica#438
Todo