Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standarize Cartesian coordinates with z pointing up #89

Closed
santisoler opened this issue Aug 7, 2019 · 0 comments · Fixed by #92
Closed

Standarize Cartesian coordinates with z pointing up #89

santisoler opened this issue Aug 7, 2019 · 0 comments · Fixed by #92
Assignees

Comments

@santisoler
Copy link
Member

Description of the desired feature

After a discussion, @leouieda and I agreed that would be better to standarize the vertical coordinate in Cartesian coordinate system pointing upwards.
The benefits of this decision are:

  • Computational heights would be positive values, saving users from converting their height coordinates of observation points to negative values.
  • The same goes for structures above the zero height, like topography. Having negative topography heights is not intuitive.
  • When specifying some source geometries (like prisms), their boundaries can be standardized as the ones in spherical coordinates are defined: w, e, s, n, bottom, top. If the vertical direction points upwards, the bottom value will be numerically lower than the top one, in the same way as tesseroids are defined.

One of the drawbacks of this idea is that the coordinate system would be left-handed. Nevertheless, this can be solved with good documentation and careful implementation of the math beneath the forward models.

This new idea also change how gravity acceleration is defined. For sake of standarization, we propose that the forward models that computes the vertical (or radial) component of the gravity acceleration return the downward component rather than the one oriented according to the new vertical direction. We agreed on this because among geophysicists the gravity is always expected to be pointing downward, thus a positive density contrast produces a positive anomaly.
This should be well specified on the documentation and on the future page about coordinates systems (#68).

Are you willing to help implement and maintain this feature? Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant