Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontal Cartesian components for point masses #119

Merged
merged 16 commits into from
Nov 29, 2019

Conversation

birocoles
Copy link
Member

@birocoles birocoles commented Nov 4, 2019

Implement horizontal Cartesian components g_northingand g_easting for point masses. This PR addresses some of #85 . Components in spherical coordinate system will be implemented in the future.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

@leouieda
Copy link
Member

leouieda commented Nov 4, 2019

@birocoles notice that your branch is out of date with respect to the master branch. You might want to merge in the changes before proceeding (you can do this locally or through Github)

@birocoles
Copy link
Member Author

Hi @santisoler! I may have done something wrong when I tried to pull things from master. Actually, I think the sanity checks are important. Whatever. I will bring this sanity check and the related test back to the code.

@birocoles
Copy link
Member Author

@santisoler , I think everything is working now.

@birocoles
Copy link
Member Author

I have just fixed some problems with too long lines. What I have to do now?

@santisoler
Copy link
Member

Thanks for tackling this @birocoles! 🥇

I think this is good to be merged. If you agree, please remove the WIP from the PR title and ask @leouieda for a review so we can merge it.
Thanks again for the hard work!

@birocoles birocoles changed the title WIP Add horizontal Cartesian components for point masses Add horizontal Cartesian components for point masses Nov 29, 2019
@birocoles
Copy link
Member Author

Thanks @santisoler

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@birocoles I'm happy with this PR 👍 Thanks for doing all this work! The numerical tests are really good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants