-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add horizontal Cartesian components for point masses #119
Conversation
bring recent changes from fatiando/harmonica master
Replace gravity with gravitational in docstrings (fatiando#117)
Add Great Britain and fix bug with distance in kernel potential cartesian
@birocoles notice that your branch is out of date with respect to the master branch. You might want to merge in the changes before proceeding (you can do this locally or through Github) |
Hi @santisoler! I may have done something wrong when I tried to pull things from master. Actually, I think the sanity checks are important. Whatever. I will bring this sanity check and the related test back to the code. |
@santisoler , I think everything is working now. |
I have just fixed some problems with too long lines. What I have to do now? |
Thanks for tackling this @birocoles! 🥇 I think this is good to be merged. If you agree, please remove the WIP from the PR title and ask @leouieda for a review so we can merge it. |
Thanks @santisoler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@birocoles I'm happy with this PR 👍 Thanks for doing all this work! The numerical tests are really good.
Implement horizontal Cartesian components
g_northing
andg_easting
for point masses. This PR addresses some of #85 . Components in spherical coordinate system will be implemented in the future.Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.