Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global gravity sample dataset #12

Merged
merged 4 commits into from
Oct 29, 2018

Conversation

santisoler
Copy link
Member

Added a global gravity sample dataset as a netCDF file downloaded from ICGEM Computation Service.
The data contains the EIGEN 6C4 release gravity_earth field which is defined as the magnitude of the gradient of the potential (including the centrifugal potential) at a given point.
It was calculated on the Earth's surface and on a regular global grid of 1.0° spacing.

Fixes #9

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@leouieda
Copy link
Member

leouieda commented Oct 26, 2018

@santis19 thanks for working on this! Please have a look at how I did this in Verde.

A few things that need to be changed:

  • Data should go in the data top-level folder
  • Add a README.md to data (see verde). It should contain a list of data files with explanations and attributions.
  • Try using compression to reduce the size of the data file as much as possible. See if you can get it down a bit from the current 2mb.

We can merge this without an example or loading function. Those can come in a later PR.

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@santisoler
Copy link
Member Author

@leouieda
See if it's good enough (and the README.md is well written).
The compression significantly reduced the file size (from 2mb to 372kb).

I think this PR is ready to be merged.

@leouieda leouieda changed the title WIP: Global gravity sample dataset Global gravity sample dataset Oct 29, 2018
@leouieda
Copy link
Member

Perfect!

@leouieda leouieda merged commit 63157a4 into fatiando:master Oct 29, 2018
@santisoler santisoler deleted the global_gravity_dataset branch October 31, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample dataset: Global gravity from ICGEM
3 participants