Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global topography data and update gravity data #23

Merged
merged 5 commits into from
Nov 7, 2018
Merged

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Nov 7, 2018

Use a 0.5 degree ETOPO1 dataset as Earth topography (will be used in
isostasy examples and Bouguer gravity). Update the global gravity data
to use EIGEN-6C4 at constant height to avoid dealing with conversion
between orthometric and geometric heights. The topography grid is in
geometric heights converted using an EIGEN-6C4 geoid.

Add functions to load these datasets using Pooch and examples for each.
Add an example calculating the gravity disturbance using the global
gravity data.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gallery is taking shape and looks good.
This PR is failing tests and docs building because the datasets cannot be found under https:/fatiando/harmonica/raw/master/data/.
If we are going to merge even with failing CI we should check that they don't fail on master afterwards.
Another way would be to create a temporary branch (and a temporary PR), change the datasets' url and then wait for CI to not fail.

Besides these observations, I'm happy with the shape harmonica is taking.

Available datasets
------------------

These are the datasets currently available:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to add the datasets available?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That README is what becomes the index page for sphinx gallery. So the examples are going to be rendered undetr that like so https://www.fatiando.org/verde/dev/sample_data/index.html

@leouieda
Copy link
Member Author

leouieda commented Nov 7, 2018

This PR is failing tests and docs building because the datasets cannot be found

I forgot to add a line to the CI builds to copy the sample data to the local folder. We don't the CIs to be making downloads every time. The downloading itself is well tested in Pooch so there shouldn't be a problem.

Use a 0.5 degree ETOPO1 dataset as Earth topography (will be used in
isostasy examples and Bouguer gravity). Update the global gravity data
to use EIGEN-6C4 at constant height to avoid dealing with conversion
between orthometric and geometric heights. The topography grid is in
geometric heights converted using an EIGEN-6C4 geoid.

Add functions to load these datasets using Pooch and examples for each.
Add an example calculating the gravity disturbance using the global
gravity data.
@leouieda leouieda merged commit f526f83 into master Nov 7, 2018
@leouieda leouieda deleted the gravity-data branch November 7, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants