Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set EQLHarmonic points to constant depth #236

Merged
merged 17 commits into from
Oct 18, 2021
Merged

Add option to set EQLHarmonic points to constant depth #236

merged 17 commits into from
Oct 18, 2021

Commits on May 14, 2021

  1. Add option to choose constant depth for EQLHarmonic 

    Rename the relative_depth parameter for depth and add a new depth_type
parameter. Keep supporting the relative_depth parameter but raise
a FutureWarning if passed. Add a new build_points method for creating
the point source coordinates based on the data points.
    @santisoler
    santisoler committed May 14, 2021
    Configuration menu
    Copy the full SHA
    31e05da View commit details
    Browse the repository at this point in the history

  2. Run black

    @santisoler
    santisoler committed May 14, 2021
    Configuration menu
    Copy the full SHA
    e48ec0a View commit details
    Browse the repository at this point in the history

  3. Fix build_points method

    @santisoler
    santisoler committed May 14, 2021
    Configuration menu
    Copy the full SHA
    5985ead View commit details
    Browse the repository at this point in the history

  4. Update EQLHarmonic tests and add new ones

    @santisoler
    santisoler committed May 14, 2021
    Configuration menu
    Copy the full SHA
    0baace4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Make _build_points method private

    @santisoler
    santisoler committed May 28, 2021
    Configuration menu
    Copy the full SHA
    98689e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Disable pylint warning on protected-access

    @santisoler
    santisoler committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    190cf51 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Improve docstring 

    Co-authored-by: Leonardo Uieda <[email protected]>
    @santisoler @leouieda
    santisoler and leouieda authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    7a9e06f View commit details
    Browse the repository at this point in the history

  2. Use fstrings on error message 

    Co-authored-by: Leonardo Uieda <[email protected]>
    @santisoler @leouieda
    santisoler and leouieda authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    ba2d70d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into eql-constant-depth

    @santisoler
    santisoler authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    e952e3b View commit details
    Browse the repository at this point in the history

  4. Improve tests by parametrizing and defining fixture 

    Define a coordinates fixture and parametrize the depth_type and expected
upward array. Create a separate test function for testing the
relative_depth parameter. By making it independent from the other test
function, we are making it easier for deprecating it in the future.
    @santisoler
    santisoler committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    a000876 View commit details
    Browse the repository at this point in the history

  5. Run black

    @santisoler
    santisoler committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    779985f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into eql-constant-depth

    @santisoler
    santisoler authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    07f8200 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into eql-constant-depth

    @santisoler
    santisoler authored Sep 13, 2021
    Configuration menu
    Copy the full SHA
    6b84fcc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Remove repeated words in docstring

    @santisoler
    santisoler authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    e5a6d5a View commit details
    Browse the repository at this point in the history

  2. Use the depth parameter on the examples

    @santisoler
    santisoler committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    e3c8156 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into eql-constant-depth

    @santisoler
    santisoler authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    9c1be71 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into eql-constant-depth

    @santisoler
    santisoler authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    5cbfddc View commit details
    Browse the repository at this point in the history