Add block-averaged sources to EquivalentSources #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leouieda
reviewed
Oct 26, 2021
There was a problem hiding this comment.
Nice work 👍 The docs need a bit of attention:
- Build the HTML to make the example and docstring look ok
- Some classes and code formatting in the example may need a fix. For example not using the
:class:directive and some missing backtics.
Otherwise looks good to me 🙂
Add missing :class: directive. Fix itemization format. Replace "anisotropic" for "oversampled in one direction".
|
@leouieda Thanks for the review! I've applied all the required changes and also added citation instructions for the gradient-boosted equivalent sources paper. Let me know what do you think and if it's ok we can merge it. |
leouieda
reviewed
Oct 27, 2021
leouieda
reviewed
Oct 27, 2021
|
Minor comments on the citation file. Otherwise, merge away! |
Remove the BibTeX entry Co-authored-by: Leonardo Uieda <[email protected]>
|
Thanks again for the review. I made another iteration of the citation instructions that looks better IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
EquivalentSourcesto use the block-averaging strategy for locating thesources introduced in Soler & Uieda
(2021). Add a new
block_sizeparameterto define the size of the blocks. Add a new example to the Gallery and test
functions for the new feature. Add citation instructions for the paper when
using the block-averaged sources.
Fixes #254