Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package requirements.txt and update the dependencies list #261

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Package requirements.txt and update the dependencies list #261

merged 6 commits into from
Oct 20, 2021

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Oct 20, 2021 •
edited
Loading

Remove scipy as dependency: it's not being directly used. Add scikit-learn
as a dependency because it's being used. Include requirements.txt on
manifest.in, exclude some files like license_notice.py and .flake8.

This PR was triggered after the issues highlighted on conda-forge/harmonica-feedstock#3

@santisoler santisoler changed the title Update dependencies Update dependencies and include requirements.txt on MANIFEST.in Oct 20, 2021
@santisoler santisoler changed the title Update dependencies and include requirements.txt on MANIFEST.in Update dependencies and include requirements.txt in MANIFEST.in Oct 20, 2021
@santisoler santisoler changed the title Update dependencies and include requirements.txt in MANIFEST.in Package requirements.txt and update the dependencies list Oct 20, 2021
@santisoler santisoler changed the title Package requirements.txt and update the dependencies list Package requirements.txt and update the dependencies list Oct 20, 2021
@santisoler santisoler merged commit 6cd8cf6 into master Oct 20, 2021
@santisoler santisoler deleted the purge-requirements branch October 20, 2021 17:20
@santisoler santisoler added the maintenance A maintenance task to improve development label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leouieda leouieda Awaiting requested review from leouieda

Assignees
No one assigned
Labels
maintenance A maintenance task to improve development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@santisoler