Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and rename pytest mark to run only with Numba enabled #273

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Oct 25, 2021

Fix bug on the require_numba mark: tests decorated only with it weren't being
tested. Now it combines the pytest.mark.use_numba decorator. Rename the
decorator to run_only_with_numba for better readability.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Fix an unwanted behaviour of the old `require_numba` decorator by
merging it with the `use_numba`.
Rename `require_numba` to `run_only_with_numba` for better understanding
of what the decorator does.
@santisoler santisoler added the bug Report a problem that needs to be fixed label Oct 25, 2021
harmonica/tests/utils.py Outdated Show resolved Hide resolved
@santisoler santisoler changed the title Fix and rename pytest mark for testing only with Numba enabled Fix and rename pytest mark to run only with Numba enabled Oct 25, 2021
@santisoler santisoler merged commit ea7947e into master Oct 25, 2021
@santisoler santisoler deleted the run_only_with_numba branch October 25, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report a problem that needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant