Simplify tests for upward derivative #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ditch the precomputed sample grid file and add new features for creating a pair of sample sources, a sample grid and some gravity fields as DataArrays.
Hey @santisoler , that looks very good for me! I'm thinking to add a little complexity to the test. It might be good to put a pair of sources with positive and negative density contrast and depth. |
LL-Geo
reviewed
Jun 28, 2022
| points = [ | ||
| [-50e3, 50e3], | ||
| [-50e3, 50e3], | ||
| [-20e3, -20e3], |
There was a problem hiding this comment.
might be good to have one shallow source and one deep source?
LL-Geo
reviewed
Jun 28, 2022
| [-20e3, -20e3], | ||
| ] | ||
|
|
||
| masses = [3.3e8, 2.9e8] |
There was a problem hiding this comment.
A positive and negative mass might be good as well?
There was a problem hiding this comment.
Agreed! You're right that the model should be a little bit more complex.
|
Thanks @LL-Geo for the review! Making the sample model more complex was a clever idea. I'm merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ditch the precomputed sample grid file and add new fixtures for creating
a pair of sample sources, a sample grid and some gravity fields as
DataArrays. Remove
netcdf4from testing dependencies.Relevant issues/PRs
Related to #299