Add a function to ignore the tesseroid with zero density or volume #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @santisoler! |
aguspesce
changed the title
Small fix in the docstring.
Instead of creating a density array with repeated values, it worth testing with a diverse density array. This way we can test that the density values we are getting are actually the ones we want to keep.
santisoler
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
This is a great work @aguspesce! I've only changed a few little things:
- I renamed the variables for the boundaries of the tesseroids to
west,east,south,northjust because that's the convention we use in Harmonica for those, - and added more diversity to the density array you define on the test function. This way we can actually test that the density values we are keeping after running
_discard_null_tesseroids()are the right ones.
I'm merging this 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I am working on
tesseroid_layerfunction, I had an error for tesseroid with zero volume.So I add a new checked in
tesseroid_gravitythat ignore the tesseroid with zero density or zero volume