Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equivalent sources figures in gallery examples #342

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

BenjMy
Copy link
Contributor

@BenjMy BenjMy commented Aug 19, 2022

Hi Fatiando team!

First I'm happy to see that the upward continuation is now live in v0.5.0. I was using it until now with the old Fatiando!

This PR is related to a documentation issue and specifically to the example in the equivalent source page

Issue: the plot of the upward continued data is empty.

Small tweak: add the region = vd.get_region(coordinates) line to the examples. This allows getting the right coordinates to grid.

Looking forward to using the upward continuation feature!

@santisoler
Copy link
Member

Thank you very much for solving this @BenjMy! As you might have seen the docs had a lot of new stuff in there and apparently we forgot to check the gallery. I'm merging this! 🚀

Like I mentioned in #341, feel free to add yourself to the AUTHORS.md file.

@santisoler santisoler changed the title Add get region to eq. source examples Fix equivalent sources figures in gallery examples Aug 23, 2022
@santisoler santisoler merged commit d7c4354 into fatiando:main Aug 23, 2022
@santisoler santisoler added bug Report a problem that needs to be fixed documentation Improvements or additions to documentation labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report a problem that needs to be fixed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants