Fix test function for empty ICGEM gdf file #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santisoler
changed the title
santisoler
added
bug
MGomezN
added a commit
that referenced
this pull request
Jun 7, 2023
Remove repeat sentences <!-- Thank you for contributing a pull request to Fatiando! 💖 👆🏽 ABOVE: Describe the changes proposed and WHY you made them. 👇🏽 BELOW: Link to any relevant issue or pull request. Please ensure you have taken a look at the CONTRIBUTING.md file in this repository (if available) and the general guidelines at https:/fatiando/community/blob/main/CONTRIBUTING.md --> **Relevant issues/PRs:** <!-- Example: "Fixes #1234" / "See also #345" / "Relevant to #111" Use keywords (e.g., Fixes, Closes) to create the links and automatically close issues when this PR is merged. See https:/blog/1506-closing-issues-via-pull-requests -->
LL-Geo
added a commit
that referenced
this pull request
Jan 13, 2024
1. Update point source use Choclo 2. Rename the kernel from kernel_g_z_spherical to kernel_gravity_u_spherical 3. Update tesseroid associate with kernel name change 4. Update Test add Choclo <!-- Thank you for contributing a pull request to Fatiando! 💖 👆🏽 ABOVE: Describe the changes proposed and WHY you made them. 👇🏽 BELOW: Link to any relevant issue or pull request. Please ensure you have taken a look at the CONTRIBUTING.md file in this repository (if available) and the general guidelines at https:/fatiando/community/blob/main/CONTRIBUTING.md --> **Relevant issues/PRs:** <!-- Example: "Fixes #1234" / "See also #345" / "Relevant to #111" Use keywords (e.g., Fixes, Closes) to create the links and automatically close issues when this PR is merged. See https:/blog/1506-closing-issues-via-pull-requests --> --------- Co-authored-by: Santiago Soler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for checking if proper errors and warnings were raised when reading an empty ICGEM gdf file was failing in my local system due to a change in the Numpy warning for the empty file. Took the opportunity to refactor the test using
pytest.raisesandpytest.warnsto capture the errors and warnings.