Clean API making some submodules private #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
aguspesce
approved these changes
Nov 25, 2022
Visualization module just offers the prism_to_pyvista function as a public function at the level of the module. The `prism` submodule will remain private.
santisoler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
forward,equivalent_sources,gravity_corrections,isostasyandtransformationssubmodules as private ones. This will enforce the usage of public functions and classes allowing developers to refactor private ones without the risk of braking backward compatibility. It also cleans up the list of options available when using autocompletion in IDEs and JupyterLab, helping the discoverability of the functions and classes we have in Harmonica.Relevant issues/PRs:
Fixes #314