Magnetic field of dipoles in Cartesian coordinates #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add forward modelling functions for dipoles: `dipole_magnetic` and `dipole_magnetic_component`. The first one computes the three components of the magnetic field, while the latter computes only one of them. The forward modelling is done using the Choclo functions for dipoles.
Inform users that they should use `dipole_magnetic` if they want to compute the three components of the magnetic vector.
7 tasks
santisoler
changed the title
santisoler
commented
May 24, 2023
santisoler
commented
May 24, 2023
santisoler
commented
May 24, 2023
Add a private function to check the shape and size of dipoles and magnetic moment vectors that is reused by the two magnetic forward modelling functions.
Add a new user guide page with examples on how to compute the magnetic fields generated by dipoles.
LL-Geo
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Looks great @santisoler !😁 A small change for the figure and some typos then it will be perfect to merge 😀
doc/_static/figures/dipoles.svg
Outdated
There was a problem hiding this comment.
The vector should point toward the bottom (negative) pole?
There was a problem hiding this comment.
haha, totally! Good catch!
Co-authored-by: Lu Li <[email protected]>
Co-authored-by: Lu Li <[email protected]>
Also, fix color of arrow head in Chrome-based browsers.
|
Thanks @LL-Geo for the review! I'm merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forward modelling functions for the magnetic field of dipoles in Cartesian coordinates:
dipole_magneticanddipole_magnetic_component. The first one computes the three components of the magnetic field, while the latter computes only one of them. The forward modelling is done using the Choclo functions for dipoles.Relevant issues/PRs:
Part of #406