Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dependabot to update GitHub Actions workflows #455

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Feb 5, 2024

The Actions we use have pinned versions and it's almost impossible to keep up with new releases of them. Add configuration for Dependabot to track the Actions versions and send pull requests when new versions are available. This only works if version numbers are pinned instead of the commit hashes. I think the benefit of being updated out weight any risk associated with this.

leouieda and others added 2 commits February 5, 2024 13:45
The Actions we use have pinned versions and it's almost impossible to
keep up with new releases of them. Add configuration for Dependabot to
track the Actions versions and send pull requests when new versions are
available. This only works if version numbers are pinned instead of the
commit hashes. I think the benefit of being updated out weight any risk
associated with this.
@santisoler
Copy link
Member

I noticed that dependabot replaces the hashes from commits with tags. Do we want to allow it to do so for actions that use our tokens?

If so, maybe we should update those comments saying we are actually pinning the commit hashes, right?

@leouieda
Copy link
Member Author

Hey Santi, I thought it would be fine. The only one we actually use is the Cancel Workflow one, which honestly, we can probably get rid of. The others are official PyPI actions, official Codecov actions, and official GitHub actions, so it shouldn't be a problem.

@leouieda
Copy link
Member Author

Now that I think about it, the only reason commits would be safer is if we audited the action to know that the particular commit doesn't do anything dangerous. We don't do this so I think the risk is pretty much the same.

@leouieda
Copy link
Member Author

Would you agree to remove the Cancel workflow actions?

@santisoler
Copy link
Member

I see. I think cancelling workflows is a nice feature, so we avoid using resources unnecessarily, but we can live with that.

I haven't look too much into it, but I think there's a way to cancel previous workflows through GitHub Actions API, specifically configuring the concurrency: https://www.meziantou.net/how-to-cancel-github-workflows-when-pushing-new-commits-on-a-branch.htm

I might need to research on that. But for now, feel free to remove it.

@leouieda
Copy link
Member Author

You can also do it manually. But yes, I think our development pace is slow enough that this isn't significant. I'll remove it here and elsewhere.

@leouieda
Copy link
Member Author

Done! Merging this in then.

@leouieda leouieda merged commit e9ae7ff into main Feb 23, 2024
20 checks passed
@leouieda leouieda deleted the dependabot branch February 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants