Raise error for zero depth value in equivalent sources #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtanker
reviewed
Aug 12, 2024
VascoSch92
reviewed
Aug 12, 2024
| @@ -178,6 +178,11 @@ def __init__( | |||
| f"Found invalid 'depth' value equal to '{depth}'. " | |||
| "It should be 'default' or a numeric value." | |||
| ) | |||
| if depth == 0: | |||
There was a problem hiding this comment.
Perhaps check if depth <= 0.
Because depth cannot be smaller than zero
There was a problem hiding this comment.
Hey @VascoSch92,
From the perspective of the equivalent source, you can have sources above the observation point. The only problem arises when you have them in the same position as the observation points.
Cheers
|
Thanks @Souza-junior for this! It's looking great, I'm merging it! 🚀 Also, thanks @VascoSch92 for the comment, and @mdtanker for reporting the bug. We'll have this bugfix in the next release. |
santisoler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise error message for zero depth values in EquivalentSources and EquivalentSourcesGB classes.
Add associated tests.
Fix #523