Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward modelling for point masses in Cartesian coordiantes #71
Forward modelling for point masses in Cartesian coordiantes #71
Changes from 7 commits
84b86bb
35e6d47
df02c8c
858ebed
e6ee2ce
ee4d1e6
2a1de8c
221466b
a316cc6
a571884
50dbbd4
29003c7
6847a49
bd7e145
d002888
f3f51b2
2fe98e3
c99564a
6d3850e
95fc562
bbbf611
39c8b71
6ccd381
a73b3fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to elaborate a bit more on the docstring (citation, definitions, equations [?]).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely! I tend to forget to do it because I know where I'm getting the equations from, but I really appreciate finding math on the docstrings when I try to use a new library or function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some math and references. I think we must make clearer that the third coordinate in Cartesian system is pointing downwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning mentioned above should be enough for making it very clear.