-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward modelling for point masses in Cartesian coordiantes #71
Merged
Merged
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
84b86bb
Extend point_mass_gravity to Cartesian coordinates
santisoler 35e6d47
Add missing use_numba mark to Cartesian test funcs
santisoler df02c8c
Add double ` where needed
santisoler 858ebed
Merge branch 'master' into point-mass-cartesian
santisoler e6ee2ce
Add gallery example for point_mass_gravity
santisoler ee4d1e6
Replace vertical for downward acceleration in docs
santisoler 2a1de8c
Put masses at different depths on example
santisoler 221466b
Fix typo
santisoler a316cc6
Remove "besides" from point mass example
santisoler a571884
Simplify point mass example title
santisoler 50dbbd4
Fix typo
santisoler 29003c7
Extend docstring of point_mass_gravity
santisoler 6847a49
Split long line from docstring in two
santisoler bd7e145
Change direction of z to downwards
santisoler d002888
Merge branch 'master' into point-mass-cartesian
santisoler f3f51b2
Rename vertical to down and add warning
santisoler 2fe98e3
Run black
santisoler c99564a
Replace vertical for down in example and tests
santisoler 6d3850e
Merge branch 'master' into point-mass-cartesian
santisoler 95fc562
Change title of point mass gallery example
santisoler bbbf611
Add note to explain the negative mass
santisoler 39c8b71
Add remainder that z points down
santisoler 6ccd381
Add definition of gravitational constant G
santisoler a73b3fd
Minor change on point mass docstring warning
santisoler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to elaborate a bit more on the docstring (citation, definitions, equations [?]).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely! I tend to forget to do it because I know where I'm getting the equations from, but I really appreciate finding math on the docstrings when I try to use a new library or function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some math and references. I think we must make clearer that the third coordinate in Cartesian system is pointing downwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning mentioned above should be enough for making it very clear.