Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lists to inmutables to avoid reflection #75

Merged
merged 4 commits into from
Jul 23, 2019

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Jul 19, 2019

Replace glq_weights and glq_nodes to tuples to avoid passing scheduled for deprecation
Numba reflected lists as arguments to Numba jitted functions.
Replace all tessseroid and coordinates lists to numpy arrays on tesseroid tests
functions when they are passed to Numba jitted functions.

Fixes #70

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Convert lists (mutable) to tuples (inmutable) in order to avoid Numba
from using reflection.
Replace lists to numpy arrays on test_tesseroid.py when passing them as
arguments of Numba jitted functions in order to avoid reflection.
@santisoler santisoler merged commit 12a1d95 into master Jul 23, 2019
@santisoler santisoler deleted the numba-reflected-list branch July 23, 2019 13:24
@leouieda
Copy link
Member

👍 thanks Santi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numba deprecation of reflected list
2 participants