Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add SciPy to Projects using Pooch #320

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

AnirudhDagar
Copy link
Contributor

Hi, we recently (merged just today) added a datasets submodule in SciPy which will be released in SciPy 1.10, with Pooch as an optional dependency. I thought it would be nice to include that in Pooch's readme doc.

Ps. Thanks for this great, easy-to-use tool. Quite useful!

@welcome
Copy link

welcome bot commented Aug 12, 2022

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@leouieda
Copy link
Member

@AnirudhDagar that is great to hear! Now we also have to worry about breaking scipy when we change things. No pressure 😰

Let us know how it's working out and if there is anything we can do on the Pooch side to make things easier.

@leouieda leouieda merged commit ee5ec6b into fatiando:main Aug 18, 2022
@welcome
Copy link

welcome bot commented Aug 18, 2022

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@AnirudhDagar
Copy link
Contributor Author

Now we also have to worry about breaking scipy when we change things.

Haha yeah, always a good thing, but that also means maybe more contributions/bug fixes from the scipy community :P

We are still discussing a few design decisions and mechanics of the scipy.datasets submodule, specifically how the import for datasets will work since pooch is an optional dep for SciPy and only affects the datasets submodule.

@leouieda
Copy link
Member

but that also means maybe more contributions/bug fixes from the scipy community :P

That would be great!

Would you mind pinging me in some of those conversations? It's good to know the various use cases so we have them in mind when planning changes.

@AnirudhDagar
Copy link
Contributor Author

Sure, I'll keep that in mind. If there is something pooch specific, I'll ping you, would be nice to have you in the discussion. 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants