Skip to content

Commit

Permalink
Merge pull request #4594 from faucetsdn/dependabot/pip/pytype-2024.10.11
Browse files Browse the repository at this point in the history
Bump pytype from 2024.9.13 to 2024.10.11
  • Loading branch information
cglewis authored Oct 17, 2024
2 parents 15a8eea + 5968c67 commit d774d67
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests-codecheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]

env:
FILES_CHANGED: "all"
CODECHECK_PY_VER: '3.10'
CODECHECK_PY_VER: "3.11"

jobs:
codecheck:
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/tests-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ on: [push, pull_request]

env:
FILES_CHANGED: "all"
CODECOV_PY_VER: "3.10"
USING_PYTYPE: "3.9,3.10,3.11,3.12"
CODECOV_PY_VER: "3.11"
STATIC_TYPE_CHECK: "3.10,3.11,3.12"

jobs:
unit-tests:
Expand Down Expand Up @@ -69,21 +69,21 @@ jobs:
- if: ${{ matrix.python-version == env.CODECOV_PY_VER }}
name: Upload codecov
uses: codecov/codecov-action@v4
- if: ${{ env.FILES_CHANGED == 'all' || env.RQ_FILES_CHANGED || env.PY_FILES_CHANGED }}
- if: ${{ (env.FILES_CHANGED == 'all' || env.RQ_FILES_CHANGED || env.PY_FILES_CHANGED)
&& contains(env.STATIC_TYPE_CHECK, matrix.python-version) }}
name: Run pytype
run: |
if ${{ contains(env.USING_PYTYPE, matrix.python-version) }} == 'true' ; then
./docker/pip_deps.sh --extra-requirements="codecheck-requirements.txt"
cd ./tests/codecheck
if [[ "${{ env.FILES_CHANGED }}" == "all" || ! -z "${{ env.RQ_FILES_CHANGED }}" ]]; then
echo "Running pytype on everything"
./pytype.sh
else
echo "Running pytype on ${{ env.PY_FILES_CHANGED }}"
./pytype.sh ${{ env.PY_FILES_CHANGED }}
fi
./docker/pip_deps.sh --extra-requirements="codecheck-requirements.txt"
cd ./tests/codecheck
if [[ "${{ env.FILES_CHANGED }}" == "all" || -n "${{ env.RQ_FILES_CHANGED }}" ]]; then
echo "Running pytype on everything"
./pytype.sh
else
echo "Running pytype on ${{ env.PY_FILES_CHANGED }}"
./pytype.sh ${{ env.PY_FILES_CHANGED }}
fi
- name: Run pyright
- if: ${{ contains(env.STATIC_TYPE_CHECK, matrix.python-version) }}
name: Run pyright
# pyright is quite fast, so easier just to run global config every time.
run: |
./docker/pip_deps.sh --extra-requirements="codecheck-requirements.txt"
Expand Down
2 changes: 1 addition & 1 deletion codecheck-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ black==24.10.0
flake8==7.1.1
pylint==3.3.1
pyright==1.1.384
pytype==2024.9.13
pytype==2024.10.11

0 comments on commit d774d67

Please sign in to comment.