fix: Correctly handle list values in _python_value_to_proto_value #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,11 +372,15 @@ def _python_value_to_proto_value( | |||
| if feast_value_type == ValueType.BYTES_LIST: | |||
| raise _type_err(sample, ValueType.BYTES_LIST) | |||
|
|
|||
| json_value = json.loads(sample) | |||
| if isinstance(json_value, list): | |||
| json_sample = json.loads(sample) | |||
There was a problem hiding this comment.
Any chance you can add a test here?
There was a problem hiding this comment.
Hi, sure thing. Did you have in mind something to check that json.loads(sample) does not error out? E.g. if there's something like a json decode error?
There was a problem hiding this comment.
Actually, it's fine. There's no test there currently so no need to add additional work here. Thank you!
franciscojavierarceo
approved these changes
Oct 9, 2024
…pped Signed-off-by: TBourtonBumble <[email protected]>
auto-merge was automatically disabled
October 9, 2024 10:55
Head branch was pushed to by a user without write access
|
Hi sorry, I missed something very dumb with the unit test, i've pushed a fix so they should be ok to re-run |
TBourtonBumble
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
_python_value_to_proto_valuedoes not properly handle lists. It will always return a list of values of length one, regardless of the number of input values.This PR aims to fix this bug, and also adds a check to ensure that the number of returned proto values is the same as the inputted values.