Protocol buffers conversion, packaging, GLib error handling #4
Conversation
Remove connstruct argument from riak_init. Add riak_putb_json which takes binary bucket and key. Add riak_getb_raw and riak_get_raw, which fetches a value from Riak. Fix fixed buffer size in writefunc.
* Don't need to check for memory allocation failure with glib malloc functions. * Don't need to worry about overflowing fixed-length buffers with g_strdup_printf.
Remove the "_raw" from riak_getb_raw and riak_get_raw be consistent with riak_putb and riak_put.
|
Hello, Sorry for a very late response, I'm simply overwhelmed by university and professional work. ;) I'm looking through your changes now and I have one question: you've decided to use GError to error reporting mainly because of integration with a package for CentOS or something else was a main reason? Back to studying your changes... ;) |
|
On Jan 30, 2012, at 4:34 AM, Piotr Nosek wrote:
No problem.
I originally pulled in GLib to fix some problems where the code wasn't checking the return value of malloc or was sprintf'ing into a fixed-length buffer. Since I had already created the dependency on GLib, I thought it would be worth making the error reporting between the various functions more consistent. When I was doing this work I was working on a project for which we were going to use Riak. The part written in C was going to be doing inserts to Riak using a binary key. (The actual key was a URL but the database was going to have many keys so we took the SHA1 of the key to reduce the in-memory size of the database.) That's why I added the interfaces for non-null-terminated keys. Unfortunately the project was canceled so I haven't done any further work with Riak since late December.
I wasn't very careful to minimize the changes I made to your code, and I apologize for that. You are, of course, welcome to take as much or as little as you want. Thanks for your code.David Hull |
I have adopted riak-c-driver for deployment in a C application that writes JSON data to a Riak database, and these commits cover the changes that I made for that work.
I converted the record get/put code to use protocol buffers. I wanted to use binary keys in my application, so I added functions that take a length parameter because my keys might contain NUL bytes.
I packaged the code with the GNU autotools, and added a pkgconfig file. I added support for building RPMs (We're using CentOS).
I changed the code to use GLib's GError for error reporting. I updated the code toto use the GLib memory allocation functions and got rid of all fixed-length buffers.
I rewrote the riak_exec_op code to use fewer system calls.