-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code parser #1203
fix: code parser #1203
Conversation
@fent can you review this PR? |
It's working, I tested |
it's working form me! |
Worked! Thank you so much, I will make an patch until the official release! diff --git a/lib/utils.js b/lib/utils.js
index 705c8dd3dd9c2aad97c21f70c95029b32a69ce1c..143ef1ff3f66f344b5df9e0312c7b812064308b2 100644
--- a/lib/utils.js
+++ b/lib/utils.js
@@ -60,7 +60,7 @@ const ESCAPING_SEQUENZES = [
{ start: "'", end: "'" },
{ start: '`', end: '`' },
// RegeEx
- { start: '/', end: '/', startPrefix: /(^|[[{:;,])\s?$/ },
+ { start: '/', end: '/', startPrefix: /(^|[[{:;,/])\s?$/ },
];
/**
If anyone wants it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fent merge please
You can simply add .patch to the end of the PR URL instead, like so https://patch-diff.githubusercontent.com/raw/fent/node-ytdl-core/pull/1203.patch to get the patch |
Didn't know that, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me
Working |
[email protected] not working Syntex error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks for the PR 👍. |
🎉 This PR is included in version 4.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Youtube changed
base.js
code, especially this regex/[{//'],]/
and it broke this package.This patch will fix the situation, but we need to refactor utils.js code to get stability in the future
Issue: #1197