Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'return fig' to plot functions #865

Closed
guigautier opened this issue May 1, 2022 · 5 comments · Fixed by #872
Closed

add 'return fig' to plot functions #865

guigautier opened this issue May 1, 2022 · 5 comments · Fixed by #872
Labels
enhancement New feature or request

Comments

@guigautier
Copy link

🚀 Feature
In visualization.py plot_subject and plot_volume is it possible de return the matplotlib fig ?

    'if output_path is not None:
        fig.savefig(output_path)
    if show:
        plt.show()
    return fig

Motivation
To send the figure to an experiment tracker.

thank you

@guigautier guigautier added the enhancement New feature or request label May 1, 2022
@dmus
Copy link
Contributor

dmus commented May 4, 2022

I also use something like this in my code to send images to an experiment tracker (ClearML for example). Would be a nice addition to torchio

@fepegar
Copy link
Owner

fepegar commented May 4, 2022 via email

@dmus
Copy link
Contributor

dmus commented May 6, 2022

I opened a pull request: #872

@fepegar
Copy link
Owner

fepegar commented May 9, 2022

Thanks for your contributions, @guigautier and @dmus!

@all-contributors please add @guigautier for ideas.

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @guigautier! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants