Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subject parameter mandatory #1029

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Make subject parameter mandatory #1029

merged 3 commits into from
Feb 11, 2023

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Feb 11, 2023

Fixes #1020.

Description

The example in GridSampler was not working, as the subject parameter is actually mandatory. This PR fixes the example and the behavior of the class.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (fd578e3) to head (860d533).
Report is 110 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   86.36%   86.47%   +0.11%     
==========================================
  Files          91       91              
  Lines        5773     5769       -4     
==========================================
+ Hits         4986     4989       +3     
+ Misses        787      780       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fepegar fepegar merged commit 9e32617 into main Feb 11, 2023
@fepegar fepegar deleted the 1020-fix-grid-sampler branch February 11, 2023 21:03
@fepegar
Copy link
Owner Author

fepegar commented Feb 11, 2023

@all-contributors please add @arthursw for bug, doc

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @arthursw! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GridSampler without subject for validation
1 participant