Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added list of masks functionality to HistogramStandardization.train #446

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

Linardos
Copy link
Contributor

@Linardos Linardos commented Feb 4, 2021

Fixes #444.

Description
As discussed, just added a functionality for multiple masks.

Checklist

  • [x ] I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • [ x] Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • [ x] In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • [ x] This pull request is ready to be reviewed
  • [ x] If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #446 (b0555fc) into master (d1c7b8f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   90.77%   90.79%   +0.02%     
==========================================
  Files         131      131              
  Lines        6501     6520      +19     
==========================================
+ Hits         5901     5920      +19     
  Misses        600      600              
Impacted Files Coverage Δ
...ms/preprocessing/test_histogram_standardization.py 100.00% <100.00%> (ø)
...eprocessing/intensity/histogram_standardization.py 94.65% <100.00%> (+0.30%) ⬆️
torchio/datasets/episurg.py 29.11% <0.00%> (ø)
torchio/datasets/mni/pediatric.py 34.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c7b8f...b0555fc. Read the comment docs.

@fepegar
Copy link
Owner

fepegar commented Feb 7, 2021

Thanks, @Linardos. I have added some small edits. Next time let's discuss the changes in the issue before opening the PR, and please follow all steps specified in CONTRIBUTING such as naming the new branch, writing commit messages, etc.

@all-contributors please add @Linardos for code.

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @Linardos! 🎉

@fepegar fepegar merged commit 2513be8 into fepegar:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants