Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress and cleanup downloaded datasets #531

Merged
merged 2 commits into from
May 11, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented May 11, 2021

Resolves #250.

Description
After downloading a dataset, remove the zip file and compress all images using gunzip.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #531 (da71472) into master (01924a8) will increase coverage by 1.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   90.47%   91.51%   +1.03%     
==========================================
  Files         132      124       -8     
  Lines        6670     6491     -179     
==========================================
- Hits         6035     5940      -95     
+ Misses        635      551      -84     
Impacted Files Coverage Δ
torchio/utils.py 89.02% <25.00%> (-2.28%) ⬇️
torchio/transforms/transform.py 84.58% <0.00%> (-2.53%) ⬇️
torchio/datasets/episurg.py 27.27% <0.00%> (-1.85%) ⬇️
torchio/datasets/ixi.py 39.04% <0.00%> (-1.70%) ⬇️
torchio/cli/apply_transform.py 76.92% <0.00%> (-0.58%) ⬇️
torchio/data/queue.py 86.00% <0.00%> (-0.28%) ⬇️
torchio/transforms/preprocessing/spatial/pad.py 89.47% <0.00%> (-0.27%) ⬇️
torchio/data/subject.py 96.52% <0.00%> (-0.10%) ⬇️
torchio/data/image.py 88.81% <0.00%> (-0.08%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5864fb...da71472. Read the comment docs.

@fepegar fepegar merged commit 178654c into master May 11, 2021
@fepegar fepegar deleted the 250-compress-cleanup-downloaded-datasets branch May 11, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress downloaded datasets
1 participant