Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error for Python < 3.8 #639

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix syntax error for Python < 3.8 #639

merged 1 commit into from
Aug 30, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Aug 30, 2021

Description
The lazy-loading features added recently broke the CI for Python<3.8. This commit makes the code compatible with older Python versions.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #639 (9eb738a) into master (cf656a7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   96.83%   96.85%   +0.01%     
==========================================
  Files         126      126              
  Lines        6516     6517       +1     
==========================================
+ Hits         6310     6312       +2     
+ Misses        206      205       -1     
Impacted Files Coverage Δ
torchio/data/io.py 96.42% <100.00%> (ø)
...o/transforms/augmentation/intensity/random_swap.py 97.02% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf656a7...9eb738a. Read the comment docs.

@fepegar fepegar merged commit e4342b2 into master Aug 30, 2021
@fepegar fepegar deleted the fix-lazy-images branch August 30, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant