Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when normalization mask is empty #656

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

fepegar
Copy link
Owner

@fepegar fepegar commented Sep 8, 2021

Fixes #655.

Checklist

  • I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • This pull request is ready to be reviewed
  • If the PR is ready and there are multiple commits, I have squashed them and force-pushed

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #656 (e4beea2) into master (449bd8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   96.82%   96.83%           
=======================================
  Files         128      128           
  Lines        6646     6657   +11     
=======================================
+ Hits         6435     6446   +11     
  Misses        211      211           
Impacted Files Coverage Δ
tests/transforms/preprocessing/test_rescale.py 100.00% <100.00%> (ø)
...chio/transforms/preprocessing/intensity/rescale.py 92.85% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449bd8f...e4beea2. Read the comment docs.

@fepegar fepegar merged commit 176bbe9 into master Sep 8, 2021
@fepegar fepegar deleted the 655-warn-empty-normalization-masks branch September 8, 2021 10:36
@fepegar
Copy link
Owner Author

fepegar commented Sep 8, 2021

@all-contributors please add @srg9000 for bug

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @srg9000! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RescaleIntensity/Normalization IndexError: cannot do a non-empty take from an empty axes.
1 participant