Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use commit and debug build of release-action #1620

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

rajatjindal
Copy link
Collaborator

@rajatjindal rajatjindal commented Jun 27, 2023

sometimes we find the canary release links to be broken for no apparent reason and this triggers failures in e2e tests and potentially user downloads as well.

while I am able to reproduce the issue, it is inconsistent. based on debugging so far, it may be a race condition to when we publish the release and a new commit is pushed to main branch.

to facilitate debugging, this PR makes two changes:

  • use a debug build from a fork of release-action. it just adds some console.log statements
  • add commit sha when creating the release (instead of pointing it to main branch by default, which can drift while new commits are pushed).

next steps:

monitor the links with above changes and:

  • if we don't run into this issue again, it would mean adding commit sha has fixed the issue. at this point stop using fork.
  • if we run into issue again, check debug logs and check if GitHub api is returning draft: false/true in the response. While it may not point us to the root cause directly, it will potentially help us identify next step for debugging.

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, though I'd like us to have in mind getting to a stable version of the action (instead of @main) once we've figured out what the problem is. I appreciate, though, that for now it's better to be able to add diagnostics and try things in the action without having to rev Spin. (Plus I guess action versions are a bit of a fiction anyway so eh.)

@rajatjindal
Copy link
Collaborator Author

I've modified it to use a tagged version (fork is on my user-account right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants