Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: to make exchange adapter #199

Merged
merged 5 commits into from
Nov 23, 2023
Merged

refactor: to make exchange adapter #199

merged 5 commits into from
Nov 23, 2023

Conversation

ejfitzgerald
Copy link
Member

@ejfitzgerald ejfitzgerald commented Nov 7, 2023 •
edited
Loading

Summary

Some code refactoring to make it easier to build standalone scripts to send exchange messages

@ejfitzgerald ejfitzgerald marked this pull request as ready for review November 7, 2023 20:09
qati
qati reviewed Nov 7, 2023
View reviewed changes
python/src/uagents/agent.py Show resolved Hide resolved
python/src/uagents/context.py Show resolved Hide resolved
jrriehl
jrriehl previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to me. I partly wonder if this should have been the original send_raw function, but I guess it's better to leave that in as well so as not to break anything.

Archento
Archento previously approved these changes Nov 8, 2023
View reviewed changes
python/src/uagents/context.py Show resolved Hide resolved
python/src/uagents/context.py Outdated Show resolved Hide resolved
@jrriehl jrriehl dismissed stale reviews from Archento and themself via 280171b November 23, 2023 16:43
@jrriehl jrriehl enabled auto-merge (squash) November 23, 2023 16:46
@jrriehl jrriehl merged commit a3d60f7 into main Nov 23, 2023
8 checks passed
@jrriehl jrriehl deleted the feat/exchange-adapter branch November 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qati qati qati left review comments

@jrriehl jrriehl jrriehl approved these changes

@Archento Archento Archento left review comments

Assignees

@jrriehl jrriehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejfitzgerald @qati @jrriehl @Archento