Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates to match aname contract-V2 #215

Merged
merged 17 commits into from
Feb 8, 2024
Merged

feat: updates to match aname contract-V2 #215

merged 17 commits into from
Feb 8, 2024

Conversation

Alejandro-Morales
Copy link
Contributor

@Alejandro-Morales Alejandro-Morales commented Jan 23, 2024

This PR performs the needed updates to match ANAME v2.0 contract with uAgents.
Now funds are required to register a domain, by default we set the registration time= 24 hours.
There are 2 main scenarios when attempting to register a domain:

  • If the domain is available it will be registered and update the record with the agent address
  • If the domain is not available (already registered and active) but the current wallet is the owner of the domain it will only update the record with the agent address
  • If the domain is not available and the current wallet is not the owner of the domain, no registration will be attempted since another wallet owns the domain

For the name registration example (examples/13-agent-name-service) domain example.agent has been registered for around 3 months for "registration test wallet". So subdomains like bob.example.agent can be registered.

@jrriehl jrriehl linked an issue Jan 31, 2024 that may be closed by this pull request
jrriehl
jrriehl previously approved these changes Feb 8, 2024
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Once we migrate the v2 contract to the main address, we can rerun the tests again and they should hopefully pass.

Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrriehl jrriehl merged commit 835af8f into main Feb 8, 2024
2 of 9 checks passed
@jrriehl jrriehl deleted the feat/aname-v2 branch February 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support ANAME v2 contract
2 participants