Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): reformat registration tests #456

Merged
merged 7 commits into from
Jul 23, 2024
Merged

feat(core): reformat registration tests #456

merged 7 commits into from
Jul 23, 2024

Conversation

Alejandro-Morales
Copy link
Contributor

No description provided.

@Alejandro-Morales Alejandro-Morales changed the title feat: reformat registration tests feat(core): reformat registration tests Jul 10, 2024
@Alejandro-Morales Alejandro-Morales linked an issue Jul 10, 2024 that may be closed by this pull request
Restructure Almanac tests in uAgents #251
Closed
Archento
Archento approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the opportunity to add a small fix to the PR but the rest looked good!

@jrriehl jrriehl merged commit b7a43a8 into main Jul 23, 2024
9 checks passed
@jrriehl jrriehl deleted the feat/mock-almanac-reg-tests branch July 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@Archento Archento Archento approved these changes

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restructure Almanac tests in uAgents
3 participants
@Alejandro-Morales @jrriehl @Archento